Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add more info in logging for the cases of exec plan fragment failed and clone #17194

Merged
merged 1 commit into from
Feb 2, 2023
Merged

[Enhancement] add more info in logging for the cases of exec plan fragment failed and clone #17194

merged 1 commit into from
Feb 2, 2023

Conversation

decster
Copy link
Contributor

@decster decster commented Feb 1, 2023 •
edited
Loading

Signed-off-by: Binglin Chang decstery@gmail.com

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Problem Summary(Required) ：

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@decster
[Enhancement] add more info in logging for the cases of exec plan fra…
e2f9646 
…gment failed and clone

Signed-off-by: Binglin Chang <decstery@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/Coordinator.java 1 1 100.00% []
🔵 com/starrocks/clone/TabletSchedCtx.java 5 5 100.00% []

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Feb 2, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

2 similar comments
@decster
Copy link
Contributor Author

decster commented Feb 2, 2023

run starrocks_admit_test

@decster
Copy link
Contributor Author

decster commented Feb 2, 2023

run starrocks_admit_test

@decster decster merged commit 23e5e68 into StarRocks:main Feb 2, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Feb 2, 2023
@decster
Copy link
Contributor Author

decster commented Feb 2, 2023

@mergify backport branch-2.5

@decster
Copy link
Contributor Author

decster commented Feb 2, 2023

@mergify backport branch-2.4

@decster
Copy link
Contributor Author

decster commented Feb 2, 2023

@mergify backport branch-2.3

mergify bot pushed a commit that referenced this pull request Feb 2, 2023
@decster @mergify
[Enhancement] add more info in logging for the cases of exec plan fra…
5700c1b 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
@mergify mergify bot mentioned this pull request Feb 2, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

backport branch-2.5

✅ Backports have been created

@mergify mergify bot mentioned this pull request Feb 2, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

backport branch-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 2, 2023
@decster @mergify
[Enhancement] add more info in logging for the cases of exec plan fra…
7fe46e7 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
@mergify mergify bot mentioned this pull request Feb 2, 2023
Closed
mergify bot pushed a commit that referenced this pull request Feb 2, 2023
@decster @mergify
[Enhancement] add more info in logging for the cases of exec plan fra…
2bfc222 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/clone/TabletSchedCtx.java
#	fe/fe-core/src/main/java/com/starrocks/qe/Coordinator.java
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

backport branch-2.3

✅ Backports have been created

decster added a commit that referenced this pull request Feb 2, 2023
@decster
[Enhancement] add more info in logging for the cases of exec plan fra…
6f959a0 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
Signed-off-by: Binglin Chang <decstery@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 3, 2023
@decster @wanpengfei-git
[Enhancement] add more info in logging for the cases of exec plan fra…
270ad24 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
decster added a commit that referenced this pull request Feb 3, 2023
@decster
[Enhancement] add more info in logging for the cases of exec plan fra…
56aeb8a 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
Signed-off-by: Binglin Chang <decstery@gmail.com>
imay pushed a commit that referenced this pull request Feb 7, 2023
@decster @mergify
[Enhancement] add more info in logging for the cases of exec plan fra…
3446c16 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
Signed-off-by: Binglin Chang <decstery@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 7, 2023
@decster @wanpengfei-git
[Enhancement] add more info in logging for the cases of exec plan fra…
e07487f 
…gment failed and clone (#17194)

Add related BE hostname to err message when query failed;
Add version info in be log when clone finished

Signed-off-by: Binglin Chang <decstery@gmail.com>
(cherry picked from commit 23e5e68)
Signed-off-by: Binglin Chang <decstery@gmail.com>
This was referenced Feb 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoyli chaoyli chaoyli approved these changes

@murphyatwork murphyatwork murphyatwork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@decster @wanpengfei-git @chaoyli @murphyatwork