Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix element_memory_usage of ArrayColumn #17151

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[BugFix] fix element_memory_usage of ArrayColumn #17151

merged 2 commits into from
Feb 1, 2023

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Feb 1, 2023 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #17035

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@silverbullet233
fix element_memory_usage of ArrayColumn
915e783 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@silverbullet233
fix code format
52631e3 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@silverbullet233
Copy link
Contributor Author

run starrocks_admit_test

@kangkaisen
Copy link
Collaborator

please add UT

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@imay imay merged commit 206f2d2 into StarRocks:main Feb 1, 2023
@github-actions github-actions bot removed the be-build label Feb 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Feb 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.4

@github-actions github-actions bot removed the 2.4 label Feb 1, 2023
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Feb 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.3

@github-actions github-actions bot removed the 2.3 label Feb 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.2

@github-actions github-actions bot removed the 2.2 label Feb 1, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

mergify bot pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @mergify
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
e650a9c 
(cherry picked from commit 206f2d2)
@mergify mergify bot mentioned this pull request Feb 1, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

backport branch-2.5

✅ Backports have been created

@mergify mergify bot mentioned this pull request Feb 1, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

backport branch-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @mergify
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
fc2f287 
(cherry picked from commit 206f2d2)
@mergify mergify bot mentioned this pull request Feb 1, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

backport branch-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @mergify
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
9cc8908 
(cherry picked from commit 206f2d2)
@mergify mergify bot mentioned this pull request Feb 1, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2023

backport branch-2.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @mergify
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
99877eb 
(cherry picked from commit 206f2d2)
wanpengfei-git pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @wanpengfei-git
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
d0dd911 
(cherry picked from commit 206f2d2)
@silverbullet233 silverbullet233 deleted the fix_17035 branch February 1, 2023 10:38
wanpengfei-git pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @wanpengfei-git
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
2df1e29 
(cherry picked from commit 206f2d2)
wanpengfei-git pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @wanpengfei-git
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
51be9cf 
(cherry picked from commit 206f2d2)
wanpengfei-git pushed a commit that referenced this pull request Feb 1, 2023
@silverbullet233 @wanpengfei-git
[BugFix] fix element_memory_usage of ArrayColumn (#17151)
e036f97 
(cherry picked from commit 206f2d2)
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request Feb 3, 2023
@silverbullet233
[BugFix] fix element_memory_usage of ArrayColumn (StarRocks#17151)
f077fc0
silverbullet233 added a commit to silverbullet233/starrocks that referenced this pull request Feb 3, 2023
@silverbullet233
[BugFix] fix element_memory_usage of ArrayColumn (StarRocks#17151)
33e36ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyehcf liuyehcf liuyehcf approved these changes

@imay imay imay approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sqlancer] asan be crash
5 participants
@silverbullet233 @kangkaisen @wanpengfei-git @imay @liuyehcf