Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Avoid call QueryCtx destructor when hold mutex #16602

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jan 13, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@stdpain stdpain enabled auto-merge (squash) January 13, 2023 13:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@stdpain
Copy link
Contributor Author

stdpain commented Jan 16, 2023

run starrocks_admit_test

@github-actions github-actions bot removed the be-build label Jan 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Jan 16, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@stdpain stdpain merged commit 15c6e64 into StarRocks:main Jan 16, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Jan 16, 2023
@stdpain
Copy link
Contributor Author

stdpain commented Jan 28, 2023

https://github.com/Mergifyio backport branch-2.3 branch-2.4 branch-2.5

mergify bot pushed a commit that referenced this pull request Jan 28, 2023
(cherry picked from commit 15c6e64)

# Conflicts:
#	be/src/exec/pipeline/fragment_executor.cpp
#	be/src/exec/pipeline/query_context.cpp
mergify bot pushed a commit that referenced this pull request Jan 28, 2023
(cherry picked from commit 15c6e64)

# Conflicts:
#	be/src/exec/pipeline/fragment_executor.cpp
#	be/src/exec/pipeline/query_context.cpp
@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2023

backport branch-2.3 branch-2.4 branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 28, 2023
stdpain added a commit that referenced this pull request Jan 28, 2023
stdpain added a commit that referenced this pull request Jan 28, 2023
(cherry picked from commit 15c6e64)
Signed-off-by: stdpain <drfeng08@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 28, 2023
(cherry picked from commit 15c6e64)
Signed-off-by: stdpain <drfeng08@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 28, 2023
kangkaisen added a commit to kangkaisen/starrocks that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants