[Enhancement] fixup isNullable of cast #15380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
run starrocks_fe_unittest |
satanson
previously approved these changes
Dec 19, 2022
kangkaisen
reviewed
Dec 19, 2022
kangkaisen
previously approved these changes
Dec 19, 2022
|
run starrocks_admit_test |
|
run starrocks_fe_unittest |
murphyatwork
previously approved these changes
Dec 19, 2022
|
run starrocks_fe_unittest |
auto-merge was automatically disabled
December 20, 2022 01:35
Head branch was pushed to by a user without write access
silverbullet233
dismissed stale reviews from murphyatwork, kangkaisen, and satanson
via
a630da2
silverbullet233
force-pushed
the
fixup_cast_nullable
branch
from
5ce0471 to
a630da2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 6 / 6 (100.00%) file detail
|
|
run starrocks_admit_test |
1 similar comment
|
run starrocks_admit_test |
murphyatwork
approved these changes
Dec 21, 2022
kangkaisen
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
currently, isNullable always returns true for cast expr, which may not make sense. actually, if target type can be fully compitable with from type, we can keep the nullable property same as child operator.
Checklist:
Bugfix cherry-pick branch check: