Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] fix BE metrics test when staros enabled #14566

Merged
merged 1 commit into from
Dec 4, 2022
Merged

[UT] fix BE metrics test when staros enabled #14566

merged 1 commit into from
Dec 4, 2022

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Dec 3, 2022

Signed-off-by: Kevin Xiaohua Cai caixiaohua@starrocks.com

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@kevincai
[UT] fix BE metrics test when staros enabled
c67985c 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

clang-tidy review says "All clean, LGTM! 👍"

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.3% 9.3% Duplication

@imay imay merged commit 54767d1 into StarRocks:main Dec 4, 2022
@github-actions github-actions bot removed the be-build label Dec 4, 2022
@kevincai kevincai deleted the fix-metrics-ut-with-staros branch December 6, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @imay @wanpengfei-git