Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] [Branch-2.3] Older versions of Analyzer disable constant folding functions for smaller int types #13647

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Nov 18, 2022

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #13648 #4691

Problem Summary(Required) :

// Because branch 2.3 introduced a more refined four arithmetic type deduction in #4691,
// but there are some non-Query Statements that also require constant expression calculation.
// For example, SetStatement still uses the old Analyzer and the old version of constant calculation
// in 2.3, and the old version of the constant calculation does not support low-precision INT,
// so the old version of the constant calculation is adapted here.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@Seaven
Copy link
Contributor

Seaven commented Nov 18, 2022

why don't modify SET_Stmt analyze result type?

@HangyuanLiu
Copy link
Contributor Author

why don't modify SET_Stmt analyze result type?

Because it is difficult to accurately deduce which expressions can be simplified by constants and which cannot in the analyze of SetVar

@kangkaisen kangkaisen merged commit 441cc91 into StarRocks:branch-2.3 Nov 22, 2022
@HangyuanLiu HangyuanLiu deleted the branch-2.3 branch November 29, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants