Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support array functions for JSON type #13155

Merged
merged 8 commits into from
Nov 10, 2022
Merged

[Feature] Support array functions for JSON type #13155

merged 8 commits into from
Nov 10, 2022

Conversation

murphyatwork
Copy link
Contributor

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #13153

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

clang-tidy review says "All clean, LGTM! 👍"

@murphyatwork
Copy link
Contributor Author

run starrocks_admit_test

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

clang-tidy review says "All clean, LGTM! 👍"

@murphyatwork
Copy link
Contributor Author

run starrocks_fe_unittest

1 similar comment
@murphyatwork
Copy link
Contributor Author

run starrocks_fe_unittest

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 4 / 7 (57.14%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/ExpressionAnalyzer.java 1 4 25.00% [725, 726, 728]
🔵 com/starrocks/catalog/FunctionSet.java 2 2 100.00% []
🔵 com/starrocks/catalog/Type.java 1 1 100.00% []

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Nov 10, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@murphyatwork murphyatwork merged commit b55e03b into StarRocks:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@stdpain stdpain stdpain approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge be-build behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array functions for JSON type
4 participants
@murphyatwork @wanpengfei-git @satanson @stdpain