-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Update iceberg version to 0.14.1 #12306
base: main
Are you sure you want to change the base?
Conversation
Another known risk is that starrocks-fe module forced to use avro-1.8.2 which introduced by spark-core, but iceberg itself has updated avro to 1.10.1 for iceberg version of 0.12.1, and updated avro to 1.10.2 for iceberg version of 0.14.1. Maybe We need to unified that to suit latest version for iceberg. |
5d17ee0
to
0195ca2
Compare
0195ca2
to
e982b7d
Compare
[FE PR Coverage Check]😞 fail : 1 / 2 (50.00%) file detail
|
Kudos, SonarCloud Quality Gate passed! |
run starrocks_clang-tidy |
Thanks for your contribution. I want to know which optimization feature you want to use when upgrading. And why choose 0.14.1. Because 0.14.1 was released last month, the latest version of iceberg is 1.0.0. |
Thanks for your time. I concern about the following features:
It would be better to keep the version iterating on a regular basis with the community. The current version we widely |
run starrocks_admit_test |
I think 0.14.1 is ok. After removing the |
@@ -38,7 +38,7 @@ under the License. | |||
<starrocks.home>${basedir}/../../</starrocks.home> | |||
<fe_ut_parallel>${env.FE_UT_PARALLEL}</fe_ut_parallel> | |||
<jacoco.version>0.8.5</jacoco.version> | |||
<iceberg.version>0.12.1</iceberg.version> | |||
<iceberg.version>0.14.1</iceberg.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to move it to parent pom properties.
What type of PR is this:
Which issues of this PR fixes :
Since iceberg has updated to the version of 0.14.1, we may update to suit more core/api optimization from that.
Problem Summary(Required) :
For current version of 0.12.1, all dependency scope is set to compile
but for version 0.14.1, all dependency is set to runtime. (iceberg-mr module is different sine 0.13+ version.)
So we need to change dependencies to suit that.
Checklist: