[Enhancement] remove some default iceberg metrics

Signed-off-by: stephen <stephen5217@163.com>
StarRocks · Jan 31, 2024 · 8dcb8d2 · 8dcb8d2
1 parent a293bb8
commit 8dcb8d2
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 6 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java b/fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java
@@ -495,12 +495,14 @@ private void collectTableStatisticsAndCacheIcebergSplit(Table table, ScalarOpera
         Types.StructType schema = nativeTbl.schema().asStruct();
 
         Map<String, MetricsModes.MetricsMode> fieldToMetricsMode = getIcebergMetricsConfig(icebergTable);
-        Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".write_metrics_mode_default",
-                DEFAULT_WRITE_METRICS_MODE_DEFAULT);
-        Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".non-default.size",
-                String.valueOf(fieldToMetricsMode.size()));
-        Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".non-default.columns",
-                fieldToMetricsMode.toString());
+        if (!fieldToMetricsMode.isEmpty()) {
+            Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".write_metrics_mode_default",
+                    DEFAULT_WRITE_METRICS_MODE_DEFAULT);
+            Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".non-default.size",
+                    String.valueOf(fieldToMetricsMode.size()));
+            Tracers.record(Tracers.Module.EXTERNAL, "ICEBERG.MetricsConfig." + nativeTbl + ".non-default.columns",
+                    fieldToMetricsMode.toString());
+        }
 
         List<ScalarOperator> scalarOperators = Utils.extractConjuncts(predicate);
         ScalarOperatorToIcebergExpr.IcebergContext icebergContext = new ScalarOperatorToIcebergExpr.IcebergContext(schema);

diff --git a/test/sql/test_iceberg/R/test_iceberg_none_write_mode b/test/sql/test_iceberg/R/test_iceberg_none_write_mode
@@ -0,0 +1,39 @@
+-- name: test_iceberg_none_write_mode
+create external catalog ice_cat_${uuid0}
+properties
+(
+    "type" = "iceberg",
+    "iceberg.catalog.type" = "hive",
+    "hive.metastore.uris" = "${iceberg_catalog_hive_metastore_uris}"
+);
+-- result:
+[]
+-- !result
+create database ice_cat_${uuid0}.ice_db_${uuid0};
+-- result:
+[]
+-- !result
+create table ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} (k1 int) properties("write.metadata.metrics.default"="none");
+-- result:
+[]
+-- !result
+insert into ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} select 1;
+-- result:
+[]
+-- !result
+select * from ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0};
+-- result:
+1
+-- !result
+drop table ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} force;
+-- result:
+[]
+-- !result
+drop database ice_cat_${uuid0}.ice_db_${uuid0};
+-- result:
+[]
+-- !result
+drop catalog ice_cat_${uuid0};
+-- result:
+[]
+-- !result
diff --git a/test/sql/test_iceberg/T/test_iceberg_none_write_mode b/test/sql/test_iceberg/T/test_iceberg_none_write_mode
@@ -0,0 +1,18 @@
+-- name: test_iceberg_none_write_mode
+create external catalog ice_cat_${uuid0}
+properties
+(
+    "type" = "iceberg",
+    "iceberg.catalog.type" = "hive",
+    "hive.metastore.uris" = "${iceberg_catalog_hive_metastore_uris}"
+);
+
+create database ice_cat_${uuid0}.ice_db_${uuid0};
+
+create table ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} (k1 int) properties("write.metadata.metrics.default"="none");
+
+insert into ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} select 1;
+select * from ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0};
+drop table ice_cat_${uuid0}.ice_db_${uuid0}.ice_tbl_${uuid0} force;
+drop database ice_cat_${uuid0}.ice_db_${uuid0};
+drop catalog ice_cat_${uuid0};