[Chore] remove JAVA_OPTS_FOR_JDK_9 and JAVA_OPTS_FOR_JDK_11 env from fe config #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fe config Signed-off-by: yandongxiao <yandongxiao@starrocks.com>
yandongxiao
force-pushed
the
chore/remove-excess-java-opts
branch
from
25d01db
to
f6989a8
Compare
kevincai
approved these changes
Jun 12, 2024
dengliu
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the inclusion of JAVA_OPTS_FOR_JDK_9, JAVA_OPTS_FOR_JDK_11, and JAVA_OPTS in the default values.yaml, their coexistence may cause confusion. According to the logic of the code in start_fe.sh, the one that takes effect is always JAVA_OPTS_FOR_JDK_11.
Therefore, we will remove JAVA_OPTS_FOR_JDK_9 and JAVA_OPTS_FOR_JDK_11 from values.yaml and set the value of JAVA_OPTS to the value of JAVA_OPTS_FOR_JDK_11.
Related Issue(s)
StarRocks/starrocks#46481
Checklist
For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).