Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging_and_related_configurations_howto.md #532

Merged
merged 1 commit into from
May 17, 2024

Conversation

DanRoscigno
Copy link
Contributor

broken link

Description

Please provide a detailed description of the changes you have made. Include the motivation for these changes, and any
additional context that may be important.

the PR should include helm chart changes and operator changes.

Related Issue(s)

Please list any related issues and link them here.

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

broken link

Signed-off-by: DanRoscigno <dan@roscigno.com>
@yandongxiao yandongxiao merged commit fe8a9cf into StarRocks:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants