[Enhancement] support be_http_port and be_port in conf #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yandongxiao <yandongxiao@starrocks.com>
kevincai
reviewed
Feb 21, 2024
| @@ -84,6 +94,15 @@ func GetPort(config map[string]interface{}, key string) int32 { | |||
| if port, err := strconv.ParseInt(v.(string), 10, 32); err == nil { | |||
| return int32(port) | |||
| } | |||
| } else if key == THRIFT_PORT { | |||
There was a problem hiding this comment.
should ignore the thrift_port config if thrift_port == 0?
Signed-off-by: yandongxiao <yandongxiao@starrocks.com>
kevincai
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the latest StarRocks version, the port names for BE and CN have been modified. The good news is that the old port names can still be used. However, if users use the new port names, Operators may not recognize them, leading to Operators potentially using default ports as liveness and readiness ports. This could result in container startup failures.
Checklist
For operator, please complete the following checklist:
make generateto generate the code.golangci-lint runto check the code style.make testto run UT.make manifeststo update the yaml files of CRD.For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).