Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Prefer to use containerPort to export service node port #421

Merged
merged 1 commit into from
Jan 26, 2024
+329 −109
Merged

[Enhancement] Prefer to use containerPort to export service node port #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 116 additions & 32 deletions config/crd/bases/starrocks.com_starrocksclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,27 +1241,48 @@ spec:
can just specify the StarRocksServicePort.Name and StarRocksServicePort.NodePort
field.
items:
description: StarRocksServicePort defines the port that
will be exposed by this service. To assign a specific
port or nodePort to a service, you should specify them
by the corresponding name or containerPort in the service
configuration. If both containerPort and name are specified,
containerPort takes precedence.
properties:
containerPort:
description: ContainerPort the service listen in pod.
description: ContainerPort of the service port. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
format: int32
type: integer
name:
description: Name of the map about coming port and target
port
description: Name of this port within the service. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
type: string
nodePort:
description: The easiest way to expose fe, cn or be
is to use a Service of type `NodePort`. The range
description: NodePort is used to specify the port on
each node on which the service is exposed. The range
of valid ports is 30000-32767
format: int32
type: integer
port:
description: Port the pod is exposed on service.
description: Port that will be exposed by this service.
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -3237,27 +3258,48 @@ spec:
can just specify the StarRocksServicePort.Name and StarRocksServicePort.NodePort
field.
items:
description: StarRocksServicePort defines the port that
will be exposed by this service. To assign a specific
port or nodePort to a service, you should specify them
by the corresponding name or containerPort in the service
configuration. If both containerPort and name are specified,
containerPort takes precedence.
properties:
containerPort:
description: ContainerPort the service listen in pod.
description: ContainerPort of the service port. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
format: int32
type: integer
name:
description: Name of the map about coming port and target
port
description: Name of this port within the service. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
type: string
nodePort:
description: The easiest way to expose fe, cn or be
is to use a Service of type `NodePort`. The range
description: NodePort is used to specify the port on
each node on which the service is exposed. The range
of valid ports is 30000-32767
format: int32
type: integer
port:
description: Port the pod is exposed on service.
description: Port that will be exposed by this service.
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -4362,27 +4404,48 @@ spec:
can just specify the StarRocksServicePort.Name and StarRocksServicePort.NodePort
field.
items:
description: StarRocksServicePort defines the port that
will be exposed by this service. To assign a specific
port or nodePort to a service, you should specify them
by the corresponding name or containerPort in the service
configuration. If both containerPort and name are specified,
containerPort takes precedence.
properties:
containerPort:
description: ContainerPort the service listen in pod.
description: ContainerPort of the service port. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
format: int32
type: integer
name:
description: Name of the map about coming port and target
port
description: Name of this port within the service. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
type: string
nodePort:
description: The easiest way to expose fe, cn or be
is to use a Service of type `NodePort`. The range
description: NodePort is used to specify the port on
each node on which the service is exposed. The range
of valid ports is 30000-32767
format: int32
type: integer
port:
description: Port the pod is exposed on service.
description: Port that will be exposed by this service.
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -5665,27 +5728,48 @@ spec:
can just specify the StarRocksServicePort.Name and StarRocksServicePort.NodePort
field.
items:
description: StarRocksServicePort defines the port that
will be exposed by this service. To assign a specific
port or nodePort to a service, you should specify them
by the corresponding name or containerPort in the service
configuration. If both containerPort and name are specified,
containerPort takes precedence.
properties:
containerPort:
description: ContainerPort the service listen in pod.
description: ContainerPort of the service port. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
format: int32
type: integer
name:
description: Name of the map about coming port and target
port
description: Name of this port within the service. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
type: string
nodePort:
description: The easiest way to expose fe, cn or be
is to use a Service of type `NodePort`. The range
description: NodePort is used to specify the port on
each node on which the service is exposed. The range
of valid ports is 30000-32767
format: int32
type: integer
port:
description: Port the pod is exposed on service.
description: Port that will be exposed by this service.
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down
37 changes: 29 additions & 8 deletions config/crd/bases/starrocks.com_starrockswarehouses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,27 +1912,48 @@ spec:
can just specify the StarRocksServicePort.Name and StarRocksServicePort.NodePort
field.
items:
description: StarRocksServicePort defines the port that
will be exposed by this service. To assign a specific
port or nodePort to a service, you should specify them
by the corresponding name or containerPort in the service
configuration. If both containerPort and name are specified,
containerPort takes precedence.
properties:
containerPort:
description: ContainerPort the service listen in pod.
description: ContainerPort of the service port. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
format: int32
type: integer
name:
description: Name of the map about coming port and target
port
description: Name of this port within the service. For
fe, port name can be http, query, rpc, edit-log, and
their default container port is 8030, 9030, 9020,
9010. For be, port name can be webserver, heartbeat,
brpc, be, and their default container port is 8040,
9050, 8060, 9060. For cn, port name can be webserver,
heartbeat, brpc, thrift, and their default container
port is 8040, 9050, 8060, 9060. For fe proxy, port
name can be http-port, and its default container port
is 8080.
type: string
nodePort:
description: The easiest way to expose fe, cn or be
is to use a Service of type `NodePort`. The range
description: NodePort is used to specify the port on
each node on which the service is exposed. The range
of valid ports is 30000-32767
format: int32
type: integer
port:
description: Port the pod is exposed on service.
description: Port that will be exposed by this service.
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down
8 changes: 0 additions & 8 deletions deploy/starrocks.com_starrocksclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,6 @@ spec:
port:
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -1507,8 +1505,6 @@ spec:
port:
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -1995,8 +1991,6 @@ spec:
port:
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down Expand Up @@ -2584,8 +2578,6 @@ spec:
port:
format: int32
type: integer
required:
- name
type: object
type: array
type:
Expand Down
Loading
Loading