Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support catalog #175

Closed
wants to merge 4 commits into from
Closed

support catalog #175

wants to merge 4 commits into from

Conversation

melin
Copy link
Contributor

@melin melin commented Jan 5, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@banmoy
Copy link
Collaborator

banmoy commented Oct 23, 2023

@melin Thanks for your contribution, and sorry for the very late reply about this feature. I have opened another PR #295 for this feature, and the difference from yours is mainly

  • rebase the newest code, and resolve conflicts
  • support more catalog methods
  • refactor the code structure

Because the code in the new PR changes too much, I suggest we continue based on the new PR, and close this. WDYT? If you agree, how about co-authoring and helping review the new PR?

@banmoy
Copy link
Collaborator

banmoy commented Oct 30, 2023

rework in #295. Close this.

@banmoy banmoy closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants