Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same structure for vehicle hardpoints and item ports #131

Open
alistair3149 opened this issue Sep 14, 2024 · 0 comments
Open

Use the same structure for vehicle hardpoints and item ports #131

alistair3149 opened this issue Sep 14, 2024 · 0 comments

Comments

@alistair3149
Copy link
Contributor

alistair3149 commented Sep 14, 2024

Issue:
The hardpoints from the Vehicle API is very similar to the ports from the Item API, yet they are using different keys which makes it confusing.

Suggestion:
The Vehicle API should use the same syntax as Item API so that it is more intuitive and maintainable. Since it is a massive change, I suggest bumping up the vehicle API to v3 while keeping v2 for backward compatibility.

Current key in Vehicle API Suggested change to match Item API
hardpoints ports
min_size sizes.min
max_size sizes.max
type compatible_types.type
sub_type compatible_types.sub_type
item equipped_item
item.children equipped_item.ports
octfx added a commit that referenced this issue Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant