Schedule Appointment Reminders only daily (#183)

# Schedule Appointment Reminders only daily

## ♻️ Current situation & Problem
*Link any open issues or pull requests (PRs) related to this PR. Please
ensure that all non-trivial PRs are first tracked and discussed in an
existing GitHub issue or discussion.*


## ⚙️ Release Notes 
*Add a bullet point list summary of the feature and possible migration
guides if this is a breaking change so this section can be added to the
release notes.*
*Include code snippets that provide examples of the feature implemented
or links to the documentation if it appends or changes the public
interface.*


## 📚 Documentation
*Please ensure that you properly document any additions in conformance
to [Spezi Documentation
Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).*
*You can use this section to describe your solution, but we encourage
contributors to document your reasoning and changes using in-line
documentation.*


## ✅ Testing
*Please ensure that the PR meets the testing requirements set by CodeCov
and that new functionality is appropriately tested.*
*This section describes important information about the tests and why
some elements might not be testable.*


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).

---------

Co-authored-by: Paul Schmiedmayer <PSchmiedmayer@users.noreply.github.com>

functions/src/functions/onSchedule.ts

@@ -19,15 +19,6 @@ export const onScheduleEveryMorning = onSchedule(
   async () => getServiceFactory().trigger().everyMorning(),
 )
 
-export const onScheduleEvery15Minutes = onSchedule(
-  {
-    schedule: '*/15 * * * *',
-    timeZone: 'America/Los_Angeles',
-    serviceAccount: serviceAccount,
-  },
-  async () => getServiceFactory().trigger().every15Minutes(),
-)
-
 export const onScheduleUpdateMedicationRecommendations = onSchedule(
   {
     schedule: '0 0 * * *',

functions/src/services/trigger/triggerService.test.ts

@@ -23,7 +23,7 @@ import { expect } from 'chai'
 import { describeWithEmulators } from '../../tests/functions/testEnvironment.js'
 
 describeWithEmulators('TriggerService', (env) => {
-  describe('every15Minutes', () => {
+  describe('everyMorning', () => {
     it('should create a message for an upcoming appointment', async () => {
       const ownerId = await env.createUser({
         type: UserType.owner,
@@ -52,13 +52,17 @@ describeWithEmulators('TriggerService', (env) => {
       const appointmentRef = env.collections.userAppointments(patientId).doc()
       await appointmentRef.set(appointment)
 
-      await env.factory.trigger().every15Minutes()
+      await env.factory.trigger().everyMorning()
 
       const patientMessages = await env.collections
         .userMessages(patientId)
         .get()
-      expect(patientMessages.docs).to.have.length(1)
-      const patientMessage = patientMessages.docs.at(0)?.data()
+      expect(patientMessages.docs).to.have.length(3)
+      const preAppointmentMessages = patientMessages.docs.filter(
+        (doc) => doc.data().type === UserMessageType.preAppointment,
+      )
+      expect(preAppointmentMessages).to.have.length(1)
+      const patientMessage = preAppointmentMessages.at(0)?.data()
       expect(patientMessage?.type).to.equal(UserMessageType.preAppointment)
       expect(patientMessage?.reference).to.equal(appointmentRef.path)
       expect(patientMessage?.completionDate).to.be.undefined
@@ -70,7 +74,7 @@ describeWithEmulators('TriggerService', (env) => {
       const clinicianMessage = clinicianMessages.docs.at(0)?.data()
       expect(clinicianMessage?.type).to.equal(UserMessageType.preAppointment)
       expect(clinicianMessage?.reference).to.equal(
-        patientMessages.docs.at(0)?.ref.path,
+        preAppointmentMessages.at(0)?.ref.path,
       )
       expect(clinicianMessage?.completionDate).to.be.undefined
 
@@ -79,7 +83,7 @@ describeWithEmulators('TriggerService', (env) => {
       const ownerMessage = clinicianMessages.docs.at(0)?.data()
       expect(ownerMessage?.type).to.equal(UserMessageType.preAppointment)
       expect(ownerMessage?.reference).to.equal(
-        patientMessages.docs.at(0)?.ref.path,
+        preAppointmentMessages.at(0)?.ref.path,
       )
       expect(ownerMessage?.completionDate).to.be.undefined
     })
@@ -124,13 +128,17 @@ describeWithEmulators('TriggerService', (env) => {
         .doc()
       await clinicianMessageRef.set(clinicianMessage)
 
-      await env.factory.trigger().every15Minutes()
+      await env.factory.trigger().everyMorning()
 
       const patientMessages = await env.collections
         .userMessages(patientId)
         .get()
-      expect(patientMessages.docs).to.have.length(1)
-      const patientMessageData = patientMessages.docs.at(0)?.data()
+      expect(patientMessages.docs).to.have.length(3)
+      const preAppointmentMessages = patientMessages.docs.filter(
+        (doc) => doc.data().type === UserMessageType.preAppointment,
+      )
+      expect(preAppointmentMessages).to.have.length(1)
+      const patientMessageData = preAppointmentMessages.at(0)?.data()
       expect(patientMessageData?.type).to.equal(UserMessageType.preAppointment)
       expect(patientMessageData?.reference).to.equal(appointmentRef.path)
       expect(patientMessageData?.completionDate).to.exist
@@ -146,9 +154,7 @@ describeWithEmulators('TriggerService', (env) => {
       expect(clinicianMessageData?.reference).to.equal(patientMessageRef.path)
       expect(clinicianMessageData?.completionDate).to.be.undefined // this message will need to be manually completed
     })
-  })
 
-  describe('everyMorning', () => {
     it('should create a message to remind about vitals', async () => {
       const userId = await env.createUser({
         type: UserType.patient,