Conversation
|
PR Review: Python 3.14 UpgradeCritical Issues ❌1. Hardcoded Python 3.13 paths in Dockerfile (lines 54, 56) COPY --from=sqlite-vec-builder /sqlite-vec-dist/vec0.so /app/.venv/lib/python3.13/site-packages/sqlite_vec/vec0.so
RUN chown app:app /app/.venv/lib/python3.13/site-packages/sqlite_vec/vec0.soImpact: Docker builds will fail. The sqlite-vec extension will be copied to a non-existent path. 2. Ruff target-version mismatch in pyproject.toml (line 53) and cli/pyproject.toml (line 48) target-version = "py313"Impact: Ruff will not apply Python 3.14 syntax rules and optimizations. 3. GitHub Actions workflow inconsistency (.github/workflows/code-quality-cli.yml) - uses: actions/setup-python@...
with:
python-version: '3.14' # ✅ Correct
- uses: astral-sh/setup-uv@...
with:
python-version: '3.13' # ❌ MismatchImpact: CI environment may have version conflicts or unexpected behavior. SummaryThis PR correctly updates Python version declarations but misses 3 critical hardcoded references that will cause runtime failures. The upgrade is incomplete and will break Docker builds and potentially CI. Recommendation: Request changes to fix all hardcoded |
54c0fe8 to
a21c371
Compare
a21c371 to
2c19898
Compare
|
Closing for the moment. We have to test/fix support with Python 3.14 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
3.13->3.14>=3.13->>=3.14.23.13->3.143.13-slim->3.14-slim3.13-slim->3.14-slimRelease Notes
python/cpython (python)
v3.14.2Compare Source
v3.14.1Compare Source
v3.14.0Compare Source
v3.13.11Compare Source
v3.13.10Compare Source
v3.13.9Compare Source
v3.13.8Compare Source
v3.13.7Compare Source
v3.13.6Compare Source
v3.13.5Compare Source
v3.13.4Compare Source
v3.13.3Compare Source
v3.13.2Compare Source
v3.13.1Compare Source
actions/python-versions (python)
v3.14.2: 3.14.2Compare Source
Python 3.14.2
v3.14.1: 3.14.1Compare Source
Python 3.14.1
v3.14.0: 3.14.0Compare Source
Python 3.14.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.