Skip to content

HA for etcd #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2019
Merged

HA for etcd #52

merged 2 commits into from
Mar 4, 2019

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Mar 1, 2019

Closes #8

Use etcd the right way, HA-friendly as an external Helm dependency.
Replace single-node etcdcoordination backend with 3-node etcd cluster via https://github.com/helm/charts/tree/master/incubator/etcd

@arm4b arm4b added the enhancement New feature or request label Mar 1, 2019
@arm4b arm4b added the RFR label Mar 1, 2019
@arm4b
Copy link
Member Author

arm4b commented Mar 1, 2019 •
edited
Loading

TODO: st2docs update once this gets merged

@arm4b arm4b requested a review from warrenvw March 4, 2019 11:28
warrenvw
warrenvw approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@warrenvw warrenvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I've verified that etcd starts correctly and is configured for use by StackStorm.

One minor note is that I don't think Etcd should be capitalized in values.yaml.

@arm4b arm4b merged commit 089cb91 into master Mar 4, 2019
@arm4b arm4b deleted the feature/etcd-cluster branch March 4, 2019 18:37
arm4b pushed a commit to StackStorm/st2docs that referenced this pull request Mar 4, 2019
Update etcd cluster details for ST2 in K8s
e7ac736 
HA enhancement based on StackStorm/stackstorm-k8s#52
@arm4b arm4b mentioned this pull request Mar 4, 2019
Merged
arm4b pushed a commit to StackStorm/st2docs that referenced this pull request Mar 4, 2019
Update etcd cluster details for ST2 in K8s
fab1c7b 
HA enhancement based on StackStorm/stackstorm-k8s#52
@arm4b arm4b mentioned this pull request Oct 23, 2019
Closed
@cognifloyd cognifloyd removed the RFR label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrenvw warrenvw warrenvw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HA for etcd cluster
3 participants
@arm4b @warrenvw @cognifloyd