Skip to content

Updated RabbitMQ-Chart to 1.46.1 & improved Reboot-Resilience #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Updated RabbitMQ-Chart to 1.46.1 & improved Reboot-Resilience #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

## In Development
* Change pullPolicy to "IfNotPresent", as Docker-Hub Ratelimits now (#159) (by @moonrail)

* Update `rabbitmq-ha` 3rd party chart from `1.44.1` to `1.46.1` (#158) (by @moonrail)
* Enable `rabbitmqErlangCookie` for `rabbitmq-ha` by default, to ensure cluster-redeployments do not fail (#158) (by @moonrail)
* Add `forceBoot` for `rabbitmq-ha` by default, to ensure cluster-redeployments do not fail due to unclean exits (#158) (by @moonrail)

## v0.32.0
* Fix a bug when datastore encrypted keys didn't work in scheduled rules. datastore_crypto_key is now shared with the ``st2scheduler`` pods (#148) (by @rahulshinde26)
Expand Down
2 changes: 1 addition & 1 deletion requirements.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: rabbitmq-ha
version: 1.44.1
version: 1.46.1
repository: https://kubernetes-charts.storage.googleapis.com/
condition: rabbitmq-ha.enabled
- name: mongodb-replicaset
Expand Down
10 changes: 9 additions & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,9 @@ rabbitmq-ha:
# Change to `false` to disable in-cluster rabbitmq deployment.
# Specify your external [messaging] connection parameters under st2.config
enabled: true
# On unclean cluster restarts forceBoot is required to cleanup Mnesia tables (see: https://github.com/helm/charts/issues/13485)
# Use it only if you prefer availability over integrity.
forceBoot: true
rabbitmqUsername: admin
# TODO: Use default random 24 character password, but need to fetch this string for use by downstream services
rabbitmqPassword: 9jS+w1u07NbHtZke1m+jW4Cj
Expand All @@ -458,7 +461,8 @@ rabbitmq-ha:
#rabbitmqMemoryHighWatermark: 512MB
#rabbitmqMemoryHighWatermarkType: absolute
# Up to 255 character string, should be fixed so that re-deploying the chart does not fail (see: https://github.com/helm/charts/issues/12371)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're defaulting rabbitmqErlangCookie value for everyone, let's at least include a warning comment as recommendation to change the default.

Suggested change
# Up to 255 character string, should be fixed so that re-deploying the chart does not fail (see: https://github.com/helm/charts/issues/12371)
# Up to 255 character string, should be fixed so that re-deploying the chart does not fail (see: https://github.com/helm/charts/issues/12371)
# NB! It's highly recommended to change the default insecure rabbitmqErlangCookie value!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning is added as well

#rabbitmqErlangCookie: 8MrqQdCQ6AQ8U3MacSubHE5RqkSfvNaRHzvxuFcG
# NB! It's highly recommended to change the default insecure rabbitmqErlangCookie value!
rabbitmqErlangCookie: 8MrqQdCQ6AQ8U3MacSubHE5RqkSfvNaRHzvxuFcG
persistentVolume:
enabled: true
# RabbitMQ application vhost, should match with 'ha' Queue Mirroring definition policy
Expand All @@ -471,6 +475,10 @@ rabbitmq-ha:
# Make sure to also change the rabbitmqMemoryHighWatermark following the formula:
# rabbitmqMemoryHighWatermark = 0.4 * resources.limits.memory
resources: {}
# As RabbitMQ enabled prometheus operator monitoring by default, disable it for non-prometheus users
prometheus:
operator:
enabled: false

##
## Etcd HA configuration (3rd party chart dependency)
Expand Down