Skip to content

Only retrieve essential fields from the API #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Only retrieve essential fields from the API #605

merged 5 commits into from
Sep 24, 2018

Conversation

Kami
Copy link
Member

@Kami Kami commented Sep 11, 2018

Included changes:

@Kami Kami changed the title [WIP] Changes for v2.9.0 release [WIP] Changes for 3.0.0 release Sep 24, 2018
@Kami Kami added this to the 3.0.0 milestone Sep 24, 2018
@Kami Kami changed the title [WIP] Changes for 3.0.0 release Changes for 3.0.0 release Sep 24, 2018
If we don't do that, an error is thrown.
@Kami
Copy link
Member Author

Kami commented Sep 24, 2018

Synced it with latest master and tests are passing now.

I also confirmed all the tabs load. I will go ahead and merge it into master.

On a related note - I don't know why we need this - d97b60d. Even if I manually specify all the attributes, I still see TypeError: Cannot read property 'properties' of undefined error in the console when loading Rules tab.

Looking at the code, it looks like something to do with payload_schema or parameters_schema, but those attributes are included so no idea why this error is throw if include_attributes is used.

@Kami Kami merged commit 9dde862 into master Sep 24, 2018
@Kami Kami deleted the v290_changes branch September 24, 2018 12:10
@Kami Kami changed the title Changes for 3.0.0 release Only retrieve essential fields from the API Sep 28, 2018
@Kami Kami modified the milestones: 3.0.0, 2.9.1 Sep 28, 2018
@Kami Kami mentioned this pull request Sep 28, 2018
@Kami Kami mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant