Fix a race between test_quickstart_key_triggers and test_quickstart_python tests #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they ran in parallel with python quickstart and some other tests which caused occasional failure because there is a race between key_triggers and python tests.
Member
Author
|
@humblearner If you feel like, it would be great if you can improve Here (https://github.com/StackStorm/st2tests/blob/ddb6c8243fcacc03e12cb8739b81b68402705214/packs/tests/actions/chains/test_key_triggers.yaml#L85) we would need to retrieve the actual trigger instance for |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is race condition between
test_quickstart_key_triggersandtest_quickstart_pythontests so they can't run in parallel.First test relies on a trigger instance being injected into the system, but second test also injects some trigger instances in the system and depending on the timing, etc. first test can fail because it will retrieve wrong trigger instance.
This pull request changes it to run
test_quickstart_key_triggersat the end after python one in the sequential manner.In the future we could ideally refactor the
key_triggerstest so it could still run in parallel, but this would need more rework (right now it just retrieves last trigger instance)./cc @humblearner