Packaging: Cherry-pick changes to runners.sh from st2-packages #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
|
|
This comment was marked as outdated.
This comment was marked as outdated.
nzlosh
approved these changes
Feb 14, 2025
cognifloyd
changed the title
cognifloyd
force-pushed
the
packaging-runners.sh
branch
from
c19bbff to
8c3ae1e
Compare
|
I just force pushed to update the cherry-picked commit messages to include a link to the original commit in st2-packages. |
This partially reverts commit 0f58e6a. This should make it easier to apply changes from st2-packages repo.
…art jobs for rhels) Cherry-picked from StackStorm/st2-packages@8fc208e
Cherry-picked from StackStorm/st2-packages@7661c69
Cherry-picked from StackStorm/st2-packages@0792494
Cherry-picked from StackStorm/st2-packages@93aa756
cognifloyd
force-pushed
the
packaging-runners.sh
branch
from
8c3ae1e to
244fe8d
Compare
|
I force pushed again to sign the commits. |
cognifloyd
requested review from
rush-skills,
guzzijones,
amanda11 and
a team
guzzijones
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.
When st2-packages was split from the st2 repo, copies of some files ended up in both repos. In particular, the copies of
st2actions/bin/runners.shdiverged, with more changes made in st2-packages following the split, and then confusion followed when we didn't know what to update.I sifted through the git history to figure out the timeline of all the changes. Ultimately, I temporarily reverted the changes in st2.git, cherry-picked the changes from st2-packages.git, and then reapplied the st2.git specific changes. I tried to preserve the git history and git authorship. I also updated the cherry-picked commit messages to include a link to the original commit.