Drop st2exporter

CHANGELOG.rst

@@ -79,6 +79,15 @@ Changed
 
   Contributed by @LiamRiddell
 
+Removed
+~~~~~~~
+
+* Removed st2exporter service. It is unmaintained and does not get installed. It was
+  originally meant to help with analytics by exporting executions as json files that
+  could be imported into something like elasticsearch. Our code is now instrumented
+  to make a wider variety of stats available to metrics drivers. #5676
+  Contributed by @cognifloyd
+
 3.7.0 - May 05, 2022
 --------------------
 

conf/HA/st2.conf.sample

@@ -26,9 +26,6 @@ virtualenv_opts = --always-copy
 [notifier]
 logging = /etc/st2/logging.notifier.conf
 
-[exporter]
-logging = /etc/st2/logging.exporter.conf
-
 [garbagecollector]
 logging = /etc/st2/logging.garbagecollector.conf
 

conf/st2.conf.sample

@@ -160,12 +160,6 @@ username = None
 # Compression level when compressors is set to zlib. Valid values are -1 to 9. Defaults to 6.
 zlib_compression_level =
 
-[exporter]
-# Directory to dump data to.
-dump_dir = /opt/stackstorm/exports/
-# location of the logging.exporter.conf file
-logging = /etc/st2/logging.exporter.conf
-
 [garbagecollector]
 # Action execution output objects (ones generated by action output streaming) older than this value (days) will be automatically deleted. Defaults to 7.
 action_executions_output_ttl = 7

conf/st2.dev.conf

@@ -121,9 +121,6 @@ logging = st2actions/conf/logging.scheduler.conf
 [notifier]
 logging = st2actions/conf/logging.notifier.conf
 
-[exporter]
-logging = st2exporter/conf/logging.exporter.conf
-
 [workflow_engine]
 logging = st2actions/conf/logging.workflowengine.conf
 

conf/st2.package.conf

@@ -25,9 +25,6 @@ virtualenv_opts = --always-copy
 [notifier]
 logging = /etc/st2/logging.notifier.conf
 
-[exporter]
-logging = /etc/st2/logging.exporter.conf
-
 [garbagecollector]
 logging = /etc/st2/logging.garbagecollector.conf
 

conf/st2.tests.conf

@@ -87,6 +87,3 @@ remote_dir = /tmp
 [notifier]
 logging = st2actions/conf/logging.notifier.conf
 
-[exporter]
-logging = st2exporter/conf/logging.exporter.conf
-

conf/st2.tests1.conf

@@ -70,5 +70,3 @@ remote_dir = /tmp
 [notifier]
 logging = st2actions/conf/logging.notifier.conf
 
-[exporter]
-logging = st2exporter/conf/logging.exporter.conf

conf/st2.tests2.conf

@@ -92,6 +92,3 @@ remote_dir = /tmp
 [notifier]
 logging = st2actions/conf/logging.notifier.conf
 
-[exporter]
-logging = st2exporter/conf/logging.exporter.conf
-

st2common/bin/migrations/v3.8/st2-drop-st2exporter-marker-collections

@@ -0,0 +1,71 @@
+#!/usr/bin/env python
+# Copyright 2022 The StackStorm Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Migration which deletes the marker collections now that st2exporter has been removed.
+Only st2exporter used the marker collections.
+
+NB: Most people will not have these collections because st2exporter was optional,
+and the collections were not configured to be created automatically.
+"""
+
+import sys
+import traceback
+
+import mongoengine as me
+
+from mongoengine.connection import get_db
+from oslo_config import cfg
+
+from st2common import config
+from st2common.service_setup import db_setup
+from st2common.service_setup import db_teardown
+
+
+MARKER_COLLECTION = "marker_d_b"
+DUMPER_MARKER_COLLECTION = "dumper_marker_d_b"
+
+
+def delete_marker_collections():
+    db = get_db()
+    collections = db.collection_names()
+
+    if MARKER_COLLECTION in collections:
+        print(f"Dropping {MARKER_COLLECTION} collection...")
+        db[MARKER_COLLECTION].drop()
+
+    if DUMPER_MARKER_COLLECTION in collections:
+        print(f"Dropping {DUMPER_MARKER_COLLECTION} collection...")
+        db[DUMPER_MARKER_COLLECTION].drop()
+
+
+def main():
+    config.parse_args()
+    db_setup()
+
+    try:
+        delete_marker_collections(display_prompt=not cfg.CONF.yes)
+        exit_code = 0
+    except Exception as e:
+        print("ABORTED: Collection deletion aborted on first failure: %s" % (str(e)))
+        traceback.print_exc()
+        exit_code = 1
+
+    db_teardown()
+    sys.exit(exit_code)
+
+
+if __name__ == "__main__":
+    main()

st2common/st2common/transport/queues.py

@@ -39,7 +39,6 @@
     "ACTIONRUNNER_CANCEL_QUEUE",
     "ACTIONRUNNER_PAUSE_QUEUE",
     "ACTIONRUNNER_RESUME_QUEUE",
-    "EXPORTER_WORK_QUEUE",
     "NOTIFIER_ACTIONUPDATE_WORK_QUEUE",
     "RESULTSTRACKER_ACTIONSTATE_WORK_QUEUE",
     "RULESENGINE_WORK_QUEUE",
@@ -76,12 +75,6 @@
 )
 
 
-# Used by the exporter service
-EXPORTER_WORK_QUEUE = execution.get_queue(
-    "st2.exporter.work", routing_key=publishers.UPDATE_RK
-)
-
-
 # Used by the notifier service
 NOTIFIER_ACTIONUPDATE_WORK_QUEUE = execution.get_queue(
     "st2.notifiers.execution.work", routing_key=publishers.UPDATE_RK