Skip to content

Add misc pylint ignores for false positives #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Add misc pylint ignores for false positives #5672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e1bf08
ignore misc pylint false-positives
cognifloyd May 12, 2021
15f1955
make pylint ignore orjson
cognifloyd May 27, 2022
850534b
Merge branch 'master' into pylint-ignores
cognifloyd Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/runners/winrm_runner/winrm_runner/winrm_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def __init__(self, response):

class WinRmBaseRunner(ActionRunner):
def pre_run(self):
# pylint: disable=unsubscriptable-object
super(WinRmBaseRunner, self).pre_run()

# common connection parameters
Expand Down
1 change: 1 addition & 0 deletions contrib/runners/winrm_runner/winrm_runner/winrm_command_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

class WinRmCommandRunner(WinRmBaseRunner):
def run(self, action_parameters):
# pylint: disable=unsubscriptable-object
cmd_command = self.runner_parameters[RUNNER_COMMAND]

# execute
Expand Down
1 change: 1 addition & 0 deletions contrib/runners/winrm_runner/winrm_runner/winrm_ps_command_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

class WinRmPsCommandRunner(WinRmBaseRunner):
def run(self, action_parameters):
# pylint: disable=unsubscriptable-object
powershell_command = self.runner_parameters[RUNNER_COMMAND]

# execute
Expand Down
3 changes: 2 additions & 1 deletion lint-configs/python/.pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ property-classes=abc.abstractproperty
[TYPECHECK]
# Note: This modules are manipulated during the runtime so we can't detect all the properties during
# static analysis
ignored-modules=distutils,eventlet.green.subprocess,six,six.moves
# orjson has type stubs, but pylint doesn't support __init__.pyi yet: https://github.com/PyCQA/pylint/issues/2873
ignored-modules=distutils,eventlet.green.subprocess,six,six.moves,orjson

[FORMAT]
max-line-length=100
Expand Down
2 changes: 1 addition & 1 deletion st2common/benchmarks/micro/test_mongo_field_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@


# Needed so we can subclass it
LiveActionDB._meta["allow_inheritance"] = True
LiveActionDB._meta["allow_inheritance"] = True # pylint: disable=no-member


# 1. Current approach aka using EscapedDynamicField
Expand Down
2 changes: 1 addition & 1 deletion st2common/bin/migrations/v3.1/st2-cleanup-policy-delayed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def main():
except Exception as e:
LOG.error(
"ABORTED: Clean up of executions with deprecated policy-delayed status aborted on "
"first failure. %s" % e.message
"first failure. %s" % e.message # pylint: disable=no-member
)
exit_code = 1

Expand Down