Make sure that a worker picks up a task only if it done with previous. #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setting prefetch_count=1 means rabbitmq employs fairdispatch to workers. This way unless a worker acknowledges a message a new message will not be delivered to the worker. This avoids the case where a blocking task or a really long running action does not do a DoS on some unsuspecting other action. - Modified the launchdev script to include no of workers. By default 1 actionrunner worker is started. Use 'tools/launchdev.sh start N' where N is number of actionrunners.
|
LGTM |
manasdk
pushed a commit
that referenced
this pull request
Sep 19, 2014
Make sure that a worker picks up a task only if it done with previous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way unless a worker acknowledges a message a new message will not
be delivered to the worker. This avoids the case where a blocking task
or a really long running action does not do a DoS on some unsuspecting
other action.
actionrunner worker is started.
Use 'tools/launchdev.sh start N' where N is number of actionrunners.