Skip to content

Fix st2.action.file_writen typo #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2020
Merged

Fix st2.action.file_writen typo #4992

merged 7 commits into from
Jul 25, 2020

Conversation

blag
Copy link
Contributor

@blag blag commented Jul 14, 2020

PR #1785 introduced a typo in the st2.action.file_writen trigger name that has gone apparently unnoticed for five years.

This PR simply fixes the typo.

Please note that this is not reverse compatible, and so it should be noted in the upgrade documentation. However, the fact that this hasn't ever been reported or fixed would seem to indicate that not many people use this trigger, so hopefully the impact is minimal.

A companion PR for st2docs is incoming.

@blag blag added the bug label Jul 14, 2020
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jul 14, 2020
@blag blag added this to the 3.3.0 milestone Jul 14, 2020
@blag
Copy link
Contributor Author

blag commented Jul 14, 2020

Since this is a backwards-incompatible change, I would recommend against merging this into ST2 v3.2.1.

Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please link the st2docs PR here.

@blag blag merged commit 2f54bf7 into master Jul 25, 2020
@blag blag deleted the fix-writen-typo branch July 25, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants