Skip to content

remove deprecated ssl and duplicate proxy host header #4966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2020
Merged

remove deprecated ssl and duplicate proxy host header #4966

merged 4 commits into from
Jun 17, 2020

Conversation

punkrokk
Copy link
Member

This PR removes:

  • the duplicate host header in the Load balancer configs for each API endpoint
  • the ssl on directive with is deprecated and redundant with listen *:443 ssl; directive

Tested

@punkrokk punkrokk added the bug label Jun 12, 2020
@punkrokk punkrokk added this to the 3.2.1 milestone Jun 12, 2020
@punkrokk punkrokk requested review from arm4b and nmaludy June 12, 2020 14:01
@punkrokk punkrokk self-assigned this Jun 12, 2020
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jun 12, 2020
arm4b
arm4b reviewed Jun 12, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

You might need to mention this bugfix in the Changelog.

nmaludy
nmaludy approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the duplicate Host entries 👍

@punkrokk
Copy link
Member Author

@armab I added this to changelog

arm4b
arm4b approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@punkrokk punkrokk merged commit 6bff642 into master Jun 17, 2020
@punkrokk punkrokk deleted the update-HA-nginx branch June 17, 2020 15:34
@punkrokk punkrokk modified the milestones: 3.2.1, 3.3.0 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@nmaludy nmaludy nmaludy approved these changes

Assignees

@punkrokk punkrokk

Labels
bug size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@punkrokk @arm4b @nmaludy