Fix the amqp connection for WorkflowExecutionHandler to pass the SSL params #4845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
|
|
mtatsuma
force-pushed
the
kombu_ssl
branch
2 times, most recently
from
bebf651 to
796865e
Compare
|
Thanks for the contribution and good catch. The fix indeed looks correct 👍 |
Kami
approved these changes
Jan 20, 2020
arm4b
reviewed
Jan 20, 2020
There was a problem hiding this comment.
@mtatsuma Can you also include a Changelog record in https://github.com/StackStorm/st2/blob/master/CHANGELOG.rst file for this fix?
arm4b
reviewed
Jan 20, 2020
mtatsuma
force-pushed
the
kombu_ssl
branch
2 times, most recently
from
c8c0d83 to
3533d02
Compare
SSL params. To pass the SSL params, get_connection() should be used instead. Related commit: dd4465a
|
I rebased and pushed again to pass the checks! |
m4dcoder
changed the title
|
Based on the linked commit, this looks like a replacement that Kami missed in the original commit. Since he's also already approved it previously, and it passes CI, I'm just going to merge it in even though technically it should get a re-review due to the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pass the SSL params, get_connection() should be used instead.
Related commit: dd4465a