Added Mongo X509 auth support #4373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Change looks good to me, but it would also be good to add some test cases for it (I believe we already have some tests for MongoDB connection constructor). |
|
Thanks again for the contribution. I fixed lint, re-generated sample config and added tests in #4391. That PR should get merged some time this week. |
Kami
added a commit
that referenced
this pull request
Oct 18, 2018
Fix lint, changelog entry, tests for #4373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some of the bootstrap scripts to include the authentication_mechanism parameter used by pymongo to authenticate. By using authentication_mechanism = 'MONGODB-X509' in st2.conf you can now use X509 certificates to login to Mongo.