add utf8 supporting for config file(yaml) #3980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Can you please also add a test case for this change (loading config which uses unicode characters)? |
|
Already added. |
cognifloyd
requested changes
Feb 6, 2018
| config = parser.parse() | ||
| print parser.config_file_path | ||
| print config | ||
| self.assertEqual(config['credentials']['password'], u'测试') |
There was a problem hiding this comment.
It looks like this 测试 doesn't match what's in st2client/tests/fixtures/test_unicode.ini: 密码
Though I like your use of "test" and "password" (translation from google translate) in the tests. :)
|
Fixed the test case in #3989 and merged it into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add utf8 supporting for config file(yaml)