Fix a bug with API user not being honored in /v1/packs/install and /v1/packs/uninstall API endpoints #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the user which performed the operating. Instead of using user which performed the operating, system user was used.
enykeev
approved these changes
Aug 24, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug with not honoring the user which performed the API operation when scheduling an execution for pack install and pack uninstall in those two corresponding API endpoints.
This means that instead of the user which performed API operation, system user (stanley) was used for those scheduled executions.
This is a regression which was introduced when we moved from scheduling executions directly for pack install and uninstall to the new API.
Thanks to @theuiz for catching and reporting this.
Resolves #3693.