Skip to content

Commit

Permalink
removing pip version check altogether for python 3.6 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
David Culbreth committed Jun 20, 2023
1 parent 32d492f commit dd160fb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ REQUIREMENTS := test-requirements.txt requirements.txt
PIP_VERSION ?= 20.3.3
SETUPTOOLS_VERSION ?= 51.3.3
PIP_OPTIONS := $(ST2_PIP_OPTIONS)
PACKAGING_VERSION ?= 23.1

ifndef PYLINT_CONCURRENCY
PYLINT_CONCURRENCY := 1
Expand Down Expand Up @@ -663,7 +662,6 @@ distclean: clean
.PHONY: .requirements
.requirements: virtualenv
$(VIRTUALENV_DIR)/bin/pip install --upgrade "pip==$(PIP_VERSION)"
$(VIRTUALENV_DIR)/bin/pip install --upgrade "packaging==$(PACKAGING_VERSION)"
# Print out pip version
$(VIRTUALENV_DIR)/bin/pip --version
# Generate all requirements to support current CI pipeline.
Expand Down
11 changes: 0 additions & 11 deletions scripts/fixate-requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
import os.path
import sys

from packaging.version import Version

# NOTE: This script can't rely on any 3rd party dependency so we need to use this code here
PY2 = sys.version_info[0] == 2
PY3 = sys.version_info[0] == 3
Expand Down Expand Up @@ -115,15 +113,6 @@ def parse_args():
return vars(parser.parse_args())


def check_pip_version():
if Version(pip.__version__) < Version("6.1.0"):
print(
"Upgrade pip, your version `{0}' " "is outdated:\n".format(pip.__version__),
GET_PIP,
)
sys.exit(1)


def load_requirements(file_path):
return tuple((r for r in parse_requirements(file_path, session=False)))

Expand Down

0 comments on commit dd160fb

Please sign in to comment.