Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request add the GeoDNS feature for ClouDNS.
Their API has 2 fields for adding a location, I choose to use only "geodns-code" because it is more user-friendly.
Following the advice from @tlimoncelli the new metadata name is
cloudns_geodns_codeMore tests have been added and they all pass!
To compare two records, i have to replace the value "DEFAULT" with an empty string temporary.
Their API always return "DEFAULT" as value by default instead of an empty string for any dns record which uses their geodns feature.
If this implementation is good enough, i will update the documentation ("ClouDNS > Metadata section")