Skip to content

INWX: support ALIAS records #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tennox
Copy link

@tennox tennox commented Mar 22, 2025

see #2856 (comment)

I have tested to confirm it works.

@tennox
Copy link
Author

tennox commented Mar 22, 2025

One weird thing though - it will update the ALIAS record on every push:

#2: ± MODIFY ALIAS tam.ma: (ipfs.target.com.domain.org. ttl=600) -> (ipfs.target.com. ttl=600)

Which I'm guessing is an error in the read value?

@eliheady
Copy link
Contributor

Hi @tennox

One weird thing though - it will update the ALIAS record on every push:

It is because the INWX API removes the trailing dot in API responses. You have to tell the provider to add it back before calculating zone corrections. This may be all that is needed to resolve the bad change detection:

@@ -311,6 +311,7 @@ func (api *inwxAPI) GetZoneRecords(domain string, meta map[string]string) (model
                        "NS":    true,
                        "SRV":   true,
                        "PTR":   true,
+                       "ALIAS": true,
                }
                if rtypeAddDot[record.Type] {
                        if record.Type == "MX" && record.Content == "." {

This will add the trailing dot to ALIAS records after pulling the zone data.

@eliheady
Copy link
Contributor

eliheady commented Apr 5, 2025

This commit by @egon0 implements changes that get ALIAS working for INWX without the unnecessary repeated change on push.

@tennox are you interested in pulling those additional changes into your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants