Skip to content

Conversation

@chris-doucette-stack
Copy link
Collaborator

Summary

This PR explicitly declares a value prop on TextInput and makes it bindable, I also added a Storybook story, mainly for testing purposes

How to test

  1. Open TextInput's story book
  2. Go down to the "Bindable Value" story and update the inputs value

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: a5887d6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit a5887d6
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/69458607d8f37b0008ba640e
😎 Deploy Preview https://deploy-preview-2107--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit a5887d6
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/69458607ccd1a000072e5f15
😎 Deploy Preview https://deploy-preview-2107--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chris-doucette-stack. I am ok to see this merged. The only thing that would be nice to have is to add a unit test case if it is not too complicated.

@dancormier and I recently discussed supporting both two-way and one-way binding for the RadioGroup and Checkbox components, so this PR comes at the right time. It brings TextInput in line with what we’re aiming to do across the rest of the form components.

I will let Dan chime in as well but apart from that small test case I don't see why we could not merge this in an express way.

Don't forget to add a changeset (run npx changeset in your terminal and follow the instructions) for the PR @chris-doucette-stack so that our pipelines will automatically create a new release for you once merged. Thank you

@giamir giamir requested a review from dancormier December 19, 2025 08:19
Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giamir's comment pretty much matches my thoughts. Seems like a nice enhancement (and one that we're working on getting in for other inputs). Besides the changeset, I think this is good to get merged.

Thanks for the contribution @chris-doucette-stack ❤️

@chris-doucette-stack chris-doucette-stack merged commit c130895 into beta Dec 19, 2025
26 of 27 checks passed
@chris-doucette-stack chris-doucette-stack deleted the cdoucette/bindable-text-input-value branch December 19, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants