chore(refactor) - refactor main.yml #481
Conversation
|
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
.github/workflows/main.yml
Outdated
| release: | ||
| name: Release | ||
| if: github.ref == 'refs/heads/main' | ||
| name: ${{ github.ref == 'refs/heads/main' && 'Release' || 'Release Beta'}} |
There was a problem hiding this comment.
It doesn't look like this work as expected @ttaylor-stack. See this screenshot from the UI checks in the PR
There was a problem hiding this comment.
I am not entirely sure though why it is not working. One small suggestion (which won't help to fix this specific issue) is to check for the beta branch instead.
${{ github.ref == 'refs/heads/beta' && 'Release Beta' || 'Release' }}
I’m suggesting this because I believe it’s preferable to use Release as the fallback. For instance, in PRs the check will be named with the generic Release even if it isn’t executed.
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Looks ready to be tested. Thanks @ttaylor-stack
* chore(refactor) - refactor main.yml (#481) * refactor main.yaml * change empty string to null * update name * refactor: update condition * test change * update name * create changeset
Closes SPARK-13.
Describe your changes
merge release and release_beta into 1 job
PR Checklist
/** ... */docsbug/enhancementand other labels as appropriateEnvironment(s) tested
Additional context
Add any other context about the PR here.