chore(deps): update dependencies and tidy up typescript typing #365
Conversation
Bumps [prosemirror-markdown](https://github.com/prosemirror/prosemirror-markdown) from 1.12.0 to 1.13.1. - [Changelog](https://github.com/ProseMirror/prosemirror-markdown/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-markdown@1.12.0...1.13.1) --- updated-dependencies: - dependency-name: prosemirror-markdown dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [prosemirror-model](https://github.com/prosemirror/prosemirror-model) from 1.19.4 to 1.24.1. - [Changelog](https://github.com/ProseMirror/prosemirror-model/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-model@1.19.4...1.24.1) --- updated-dependencies: - dependency-name: prosemirror-model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [prosemirror-view](https://github.com/prosemirror/prosemirror-view) from 1.33.3 to 1.37.1. - [Changelog](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md) - [Commits](ProseMirror/prosemirror-view@1.33.3...1.37.1) --- updated-dependencies: - dependency-name: prosemirror-view dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ror-markdown-1.13.1' into jsmb/update-deps
…ror-model-1.24.1' into jsmb/update-deps
…ror-view-1.37.1' into jsmb/update-deps
giamir
changed the title
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Thanks for the PR. ❤️
Changes look reasonable to me so far, but there are some unit and e2e tests failing we should look into before merging. It might also be the upgraded version of the libraries break our test expectations. Hopefully that's not the case because it could make the upgrade not as straightforward.
Once tests are passing I will take another look.
Thank you
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Looks good to me. I will let @dancormier also take a look. If he cannot find anything as well we are good to merge. Thanks a lot for helping us upgrade few dependencies. ❤️
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
Ran the tests, spun up the editor locally, and checked out the code. Everything ran/looked good to me, so this gets my stamp of approval. Thanks for this @threefjefff!
3 participants
Bumping version of prosemirror and markdown-it to latest.
This necessitated a cleanup of how we call markdown-it's types and utility functions; rather than reaching into the internals, this now references the public interface.