-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Propose vector-set API #2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgravell
wants to merge
26
commits into
main
Choose a base branch
from
marc/vectorsets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Propose vector-set API #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional thoughts on FastHash:
|
- misc FastHash core improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per https://redis.io/docs/latest/develop/data-types/vector-sets/
VectorSet...
VLINKS
; the server returns this as nested data, but the nesting is not meaningful to the caller (instead being related to the server core), so I've flattened the resultVectorSetIntegrationTests
, in particularVectorSetSimilaritySearch_WithFilter
is useful for overview - since the main two primary APIs areVADD
andVSIM
Lease<T>
rather thanT[]
. Inputs areReadOnlyMemory<T>
; the exception to this isstring
data for JSON and filters; these are explicitly text, never blobs, soRedisValue
seems inappropriate. I think forcingstring
is OK hereVectorSet*
bits out viapartial
files; I will follow this up with "everything else" (.Strings.cs, .Hashes.cs) in a separate PRThis PR also introduces the start of a new literal-matching API, ala
FastHash
. It is intended that this will be extended at a later date.CI: may be dependent on the
vectorset
module; if it fails, I'll add suitable validation. AllVectorSetTests
pass locally: