-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2251: Fixes missing activation of the sub leg during initial endpoint discovery #2268
2251: Fixes missing activation of the sub leg during initial endpoint discovery #2268
Conversation
<TargetFrameworks>net461;netstandard2.0;net472;netcoreapp3.1;net5.0</TargetFrameworks> | ||
<!-- <TargetFrameworks>net461;netstandard2.0;net472;netcoreapp3.1;net5.0</TargetFrameworks> --> | ||
<TargetFrameworks>netstandard2.0;net472;netcoreapp3.1;net5.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was too lazy to install net461
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, you don't have to install it to build for it - packages pull it in via NuGet :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was down a few days here but this is spot on - added some tests around the cases it happens to prevent regressions and detect what's happening. Also tweaked the logging to show a bit more.
@iteplov Thank you for this! Hugely appreciated time saver <3 |
Allegedly fixes #2251 and #2265 but likely introduces all kinds of regressions.