Migrate create-pr to ziro-cli #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-sadakhom
commented
Nov 10, 2025
Comment on lines
+30
to
+36
| fun fromJson(reader: JsonReader, customScalarAdapters: CustomScalarAdapters): URI { | ||
| return URI(reader.nextString()!!) | ||
| } | ||
|
|
||
| fun toJson(writer: JsonWriter, customScalarAdapters: CustomScalarAdapters, value: URI) { | ||
| writer.value(value.toString()) | ||
| } |
Member
Author
There was a problem hiding this comment.
these are needed to support one of the new queries
justin-sadakhom
commented
Nov 10, 2025
Comment on lines
-39
to
-58
| # No need to get all pages as issues don't realistically have >100 | ||
| connectedPrs(first: 5) { | ||
| nodes { | ||
| id | ||
| number | ||
| state | ||
| htmlUrl | ||
| pullRequestObject { | ||
| state | ||
| } | ||
| repository { | ||
| name | ||
| } | ||
| assignees { | ||
| nodes { | ||
| login | ||
| } | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
no longer pull in PR info as part of the issue because these will be fetched separately as part of the pull request model
justin-sadakhom
commented
Nov 14, 2025
gradle.properties
Outdated
| @@ -1 +1,2 @@ | |||
| kotlin.code.style=official | |||
| ziro.cli.version=21255_migrate-create-pr-to-ziro-cli | |||
Member
Author
There was a problem hiding this comment.
will change this to the proper version before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21255
QA
None for this PR.