feat: added ability to override mirai parsers and action_parsers.#81
Conversation
|
Hey @khanjasir90, The analyze check is failing due to an unused import. Please check it. https://github.com/BuildMirai/mirai/actions/runs/12608379968/job/35142662480?pr=81 |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for this great work 🎉
Please check my suggestions.
| @@ -16,24 +16,14 @@ class MiraiRegistry { | |||
|
|
|||
| bool register(MiraiParser parser) { | |||
There was a problem hiding this comment.
@khanjasir90 Can we add an optional param called "bool override". And the parser will be overridden only of the value is true.
| return true; | ||
| } | ||
|
|
||
| Future<dynamic> registerAll(List<MiraiParser> parsers) { |
There was a problem hiding this comment.
Also, please add the same logic to registerAll and registerAllActions functions.
There was a problem hiding this comment.
Update the registerAll and update registerAllActions functions with the same logic
|
Hey @khanjasir90, There is some formatting issue. Can you please run |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for this amazing PR @khanjasir90 🥇
…tion-override-feat feat: added ability to override mirai parsers and action_parsers.
2 participants
Description
Related Issues
Closes #17
Type of Change