feat: add stacSliverToBoxAdapter widget, parser,example and documentation#423
Conversation
📝 WalkthroughWalkthroughAdds first-class SliverToBoxAdapter support: new StacSliverToBoxAdapter model with JSON (de)serialization, a parser that renders Flutter SliverToBoxAdapter, parser registration in the framework, WidgetType enum value, exports, docs, and example gallery assets. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/widgets/sliver_to_box_adapter.mdx`:
- Around line 6-8: Update the prose describing the widget to hyphenate the
compound adjective: replace occurrences of "sliver to box adapter" with
"sliver-to-box-adapter" in the sentence that mentions "The Stac
SliverToBoxAdapter allows you to build a Flutter sliver to box adapter widget
using JSON." Ensure the phrase "sliver-to-box-adapter widget" appears
consistently (e.g., in the line referencing the official documentation) and keep
the class name "SliverToBoxAdapter" unchanged.
In `@packages/stac_core/lib/foundation/specifications/widget_type.dart`:
- Around line 210-211: The doc comment for the enum value sliverToBoxAdapter is
incorrect (it says "Sliver app bar widget"); update the comment above the
sliverToBoxAdapter enum member in widget_type.dart to accurately describe that
it represents a SliverToBoxAdapter widget (e.g., "SliverToBoxAdapter widget" or
similar). Ensure the updated comment is concise and matches the naming/style of
other enum docs in the same file.
packages/stac_core/lib/foundation/specifications/widget_type.dart
Outdated
Show resolved
Hide resolved
|
Hi @divyanshub024 , @Potatomonsta 👋, |
|
@akhil-ge0rge PR checks are failing. Please check. |
|
@akhil-ge0rge I'm unable to run the example app, please check it out. |
The example app is currently failing because the supporting widget for Since that PR hasn’t been merged yet, the example doesn’t run as expected. Would it be okay if I remove the example from this PR and submit it in a separate PR after both PRs are merged? |
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for this awesome PR @akhil-ge0rge. 🎉 Please check my suggestions below
examples/stac_gallery/assets/json/sliver_to_box_adapter_example.json
Outdated
Show resolved
Hide resolved
packages/stac_core/lib/widgets/sliver_to_box_adapter/stac_sliver_to_box_adapter.dart
Outdated
Show resolved
Hide resolved
divyanshub024
left a comment
There was a problem hiding this comment.
Thank you for your awesome contribution @akhil-ge0rge 🎉
Description
This PR introduces support for
stacSliverToBoxAdapterby adding a new widget model and its corresponding parser.Related Issues
Closes #422
Type of Change
Summary by CodeRabbit
New Features
Documentation
Examples
✏️ Tip: You can customize this high-level summary in your review settings.