Closed
Conversation
… app version registration
…sion satisfaction check
Feature/version
…orts in stac_registry.dart and stac.dart
Feature/flutter35
|
lstonussi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe PR extends the STAC framework with build number tracking and version/platform-based widget gating. It introduces a new version management system with conditional operators, adds custom color parser injection, updates theme parsers to use newer Flutter widget data types, and includes comprehensive tests for the version system. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Stac as Stac Framework
participant Registry as StacRegistry
participant Parser as Widget Parser
participant VersionCheck as Version Validator
rect rgb(200, 240, 220)
Note over App,Registry: Initialization Phase
App->>Stac: initialize(buildNumber: 42)
Stac->>Registry: registerBuildNumber(42)
Registry->>Registry: store _buildNumber
Stac->>Stac: setParseCustomColor(customFn)
Stac->>Registry: parseCustomColor = customFn
end
rect rgb(220, 240, 260)
Note over Parser,VersionCheck: Runtime Widget Parsing Phase
App->>Stac: fromJson(widgetConfig)
Stac->>Stac: extract version constraints
alt version && buildNumber constraints present
Stac->>VersionCheck: isSatisfied(buildNumber: 42)
VersionCheck->>VersionCheck: evaluate condition
alt condition NOT satisfied
VersionCheck-->>Stac: constraint failed
Stac->>Stac: log warning, return null
else condition satisfied
VersionCheck-->>Stac: constraint passed
end
end
alt platform constraint present
Stac->>Stac: check current platform
alt platform mismatch
Stac->>Stac: log warning, return null
end
end
Stac->>Parser: continue parsing
Parser->>Parser: parse widget properties
alt custom color needed
Parser->>Registry: parseCustomColor?.call(colorStr)
Registry-->>Parser: custom Color or null
end
Parser-->>App: return parsed Widget
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented new platform-specific widgets functionality in the Stac framework. It's now possible to specify on which platforms a widget should be rendered through the
platformproperty in JSON.Features:
platformproperty: Can be a single string or a list of stringsnulland logs an informative messageandroid,fuchsia,ios,linux,macos,windowsUsage examples:
Multiple platforms:
{ "platform": ["android", "ios"], "type": "text", "data": "Widget only for mobile" }Single platform:
{ "platform": "android", "type": "text", "data": "Widget only for Android" }Behavior:
nulland logs:Related Issues
Closes #
Type of Change
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.