feat: Add support for the Divider widget#20
Conversation
|
Hey @bhattkrutij!! Analyze and format checks are failing. Can you please check. |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thank you for this PR 🚀
Please check my suggested changes.
pubspec.yaml
Outdated
| build_runner: ^2.4.14 | ||
| dependencies: | ||
| mirai: ^0.7.2 |
There was a problem hiding this comment.
We don't need to add these dependencies.
There was a problem hiding this comment.
@divyanshub024 without it given error. to code.removed.
| part 'mirai_divider.freezed.dart'; // Auto-generated Freezed file | ||
| part 'mirai_divider.g.dart'; // Auto-generated JSON serialization file |
There was a problem hiding this comment.
These 2 generated files are missing. We need to include them as well.
| export 'package:mirai/src/parsers/mirai_text_style/mirai_text_style.dart'; | ||
| export 'package:mirai/src/parsers/mirai_theme/mirai_theme.dart'; | ||
| export 'package:mirai/src/parsers/mirai_wrap/mirai_wrap.dart'; | ||
| export 'package:mirai/src/parsers/mirai_divider/mirai_divider.dart'; |
There was a problem hiding this comment.
@divyanshub024 .Thanks for the guidance. i have pushed code with changes.
Thank you.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@bhattkrutij |
I had run below commands |
❌ Deploy Preview for buildmirai failed.
|
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Great work @bhattkrutij 💯 🎉
|
thank you @divyanshub024 for giving me chance to work on this.looking forward to contribute more. |
…r-widget feat: Add support for the Divider widget
2 participants
Description
This PR introduces support for the Divider widget. It adds a new feature that allows the use of customizable dividers in the UI, including options for thickness, height, and color.This feature is useful for creating styled dividers in a server-driven UI, allowing dynamic customization based on JSON input.
Key changes:
Dividerwidget with customizable properties (thickness, height, color).Related Issues
Closes #15
Type of Change