Feat : Adding AspectRatio, FittedBox, LimitedBox Widgets#120
Feat : Adding AspectRatio, FittedBox, LimitedBox Widgets#120divyanshub024 merged 21 commits intoStacDev:devfrom
Conversation
MohamedAbd0
changed the title
MohamedAbd0
changed the title
website/docs/widgets/aspect_ratio.md
Outdated
| ```json | ||
| { | ||
| "type": "aspectRatio", | ||
| "aspectRatio": 4 / 3, |
There was a problem hiding this comment.
Why color is showing?
There was a problem hiding this comment.
because used '/', so I will convert it to double.
website/docs/widgets/fitted_box.md
Outdated
|
|
||
| --- | ||
|
|
||
| ## Enums |
There was a problem hiding this comment.
I feel we should have separate documentation section for this kind of painting, structuring and styling elements like BoxFit, MiraiAlignmentDirectional, Clip etc.
There was a problem hiding this comment.
sure, I will make separate documentation.
ishanvaghani
left a comment
ishanvaghani
left a comment
There was a problem hiding this comment.
Thanks @MohamedAbd0 for you contribution.
|
@ishanvaghani all comments are done. |
|
Hey @MohamedAbd0, A suggestion here for the future. Please keep the different widgets in different PRs if they are not linked together. This makes the review process much easier. |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Hey @MohamedAbd0, Once again thanks for such a great PR. Please check my suggestions.
packages/mirai/lib/src/parsers/mirai_visibility/mirai_visibility.dart
Outdated
Show resolved
Hide resolved
|
Hi @divyanshub024, I solved all the comments you can check now. |
divyanshub024
changed the title
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for the contribution 🎉
Feat : Adding AspectRatio, FittedBox, LimitedBox Widgets
3 participants
Description
Adding support Adding AspectRatio And FittedBox Widgets
Related Issues
Closes #121
Type of Change