Skip to content

Added Documentation for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser#115

Merged
divyanshub024 merged 15 commits intoStacDev:devfrom
ShalmonAnandas:dev
Jan 21, 2025

Conversation

@ShalmonAnandas
Copy link
Contributor

@ShalmonAnandas ShalmonAnandas commented Jan 17, 2025

Description

Docs for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser

Related Issues

Closes #75
Closes #76
Closes #116
Closes #117
Closes #118

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@ShalmonAnandas ShalmonAnandas changed the title Added Documentation for MiraiTableParse Added Documentation for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser Jan 17, 2025
@ishanvaghani
Copy link
Contributor

Thanks @ShalmonAnandas for contribution
border side, table border and table_row are not widgets there are atoms(elements) we can either add of this in same file or create separate section like Mirai Atoms or Elements or Styles @divyanshub024

@ShalmonAnandas
Copy link
Contributor Author

ShalmonAnandas commented Jan 17, 2025

@ishanvaghani I was thinking the same thing. What if we follow the same nomenclature that flutter follows of having widgets, rendering, painting, etc? Or if we don't want to use flutter keywords, we should come up with clear category names to divide these into.

@ishanvaghani
Copy link
Contributor

You are right, we can use flutter's nomenclature as well. @divyanshub024 let us know your thoughts

@divyanshub024
Copy link
Member

I think we can add it under the section "Styles and Attributes". What do you guys think? @ishanvaghani @ShalmonAnandas @vinothvino42

Copy link
Member

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. 💯
Please check my suggestions.

@ishanvaghani
Copy link
Contributor

I think we can add it under the section "Styles and Attributes". What do you guys think? @ishanvaghani @ShalmonAnandas @vinothvino42

Yes, if we are using styles specific to widgets then it make sense to add it inside that widget file but for general style i feel should have separate sections so we don't need to write same style again and again.

@ShalmonAnandas
Copy link
Contributor Author

@divyanshub024 , @ishanvaghani requested changes are done. Please review whenever you next get time.

Copy link
Member

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @ShalmonAnandas 💯

@divyanshub024 divyanshub024 merged commit a983a3e into StacDev:dev Jan 21, 2025
@ishanvaghani
Copy link
Contributor

Thanks @ShalmonAnandas for your contribution 🚀

lstonussi pushed a commit to SuaMusica/stac that referenced this pull request Feb 25, 2026
Added Documentation for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants