Added Documentation for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser#115
Conversation
|
Thanks @ShalmonAnandas for contribution |
|
@ishanvaghani I was thinking the same thing. What if we follow the same nomenclature that flutter follows of having widgets, rendering, painting, etc? Or if we don't want to use flutter keywords, we should come up with clear category names to divide these into. |
|
You are right, we can use flutter's nomenclature as well. @divyanshub024 let us know your thoughts |
|
I think we can add it under the section "Styles and Attributes". What do you guys think? @ishanvaghani @ShalmonAnandas @vinothvino42 |
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for the PR. 💯
Please check my suggestions.
Yes, if we are using styles specific to widgets then it make sense to add it inside that widget file but for general style i feel should have separate sections so we don't need to write same style again and again. |
|
@divyanshub024 , @ishanvaghani requested changes are done. Please review whenever you next get time. |
divyanshub024
left a comment
There was a problem hiding this comment.
Thank you for your contribution @ShalmonAnandas 💯
|
Thanks @ShalmonAnandas for your contribution 🚀 |
Added Documentation for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser
Description
Docs for MiraiTableParser, MiraiTableBorderParser, MiraiTableRowParser, MiraiTableCellParser, MiraiBorderSideParser
Related Issues
Closes #75
Closes #76
Closes #116
Closes #117
Closes #118
Type of Change