feat: Added support for snackbar#103
Conversation
# Conflicts: # examples/mirai_gallery/assets/json/home_screen.json
|
|
||
| scaffoldMessenger.showSnackBar( | ||
| SnackBar( | ||
| content: Mirai.fromJson(model.content, context) ?? SizedBox(), |
There was a problem hiding this comment.
Can you change the SizedBox to SizedBox.shrink()
There was a problem hiding this comment.
I feel this one was not necessary.
There was a problem hiding this comment.
Should i revert it back?
There was a problem hiding this comment.
Nope, it's fine. Just give me some time to review your PR. Sorry, I got super busy.
website/docs/actions/snack_bar.md
Outdated
| @@ -0,0 +1,55 @@ | |||
| # SnackBar | |||
|
|
|||
| Mirai snakBar allows you to show the Flutter SnackBar using JSON. | |||
There was a problem hiding this comment.
Can you fix this typo?
|
Resolved PR comments |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for such a great PR @ishanvaghani !! Everything looks great, just a few typos.
| part 'mirai_beveled_rectangle_border.g.dart'; | ||
|
|
||
| @freezed | ||
| class MiralBeveledRectangleBorder with _$MiralBeveledRectangleBorder { |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
| part 'mirai_circle_border.g.dart'; | ||
|
|
||
| @freezed | ||
| class MiralCircleBorder with _$MiralCircleBorder { |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
| part 'mirai_continous_rectangle_border.g.dart'; | ||
|
|
||
| @freezed | ||
| class MiralContinousRectangleBorder with _$MiralContinousRectangleBorder { |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
| part 'mirai_rounded_rectangle_border.g.dart'; | ||
|
|
||
| @freezed | ||
| class MiralRoundedRactangleBorder with _$MiralRoundedRactangleBorder { |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
| } | ||
|
|
||
| @freezed | ||
| class MiralShapeBorder with _$MiralShapeBorder { |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
website/docs/actions/snack_bar.md
Outdated
| | margin | `MiraiEdgeInsets` | Empty space to surround the snack bar. | | ||
| | padding | `MiraiEdgeInsets` | The amount of padding to apply to the snack bar's content and optional action. | | ||
| | width | `double` | The width of the snack bar. | | ||
| | shape | `MiralShapeBorder` | The shape of the snack bar. | |
There was a problem hiding this comment.
Typo here. It should be Mirai, not Miral.
|
Done with changes |
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thanks for the contribution @ishanvaghani 🎉
feat: Added support for snackbar
3 participants
Description
Added support for snackbar
Added documentation
Created category file for Mirai Actions
Related Issues
Closes #102
Screenshots
XRecorder_20250113_01.mp4
Type of Change