Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train/Eval Mode Support #39

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Conversation

ayeright
Copy link
Contributor

@ayeright ayeright commented Sep 3, 2021

Switch policies between train and eval mode.

Description

A recent PR in the stable-baselines3 library modified the policies so that they were switched between train and eval mode at the appropriate times. @araffin requested that this change also be implemented in this library. This PR makes this change for QR-DQN and TQC.

Context

  • I have raised an issue to propose this change (required)

An issue was raised in the stable-baseline3 github.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • The functionality/performance matches that of the source (required for new training algorithms or training-related features).
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have included an example of using the feature (required for new features).
  • I have included baseline results (required for new training algorithms or training-related features).
  • I have updated the documentation accordingly.
  • I have updated the changelog accordingly (required).
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin changed the title Dev Train/Eval Mode Support Sep 3, 2021
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR =)
I will wait for DLR-RM/stable-baselines3#558 to be merge so I can release a new version

@araffin araffin merged commit b2e7126 into Stable-Baselines-Team:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants