Skip to content

Upgrade protobuf and grpcio #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
noamt wants to merge 3 commits into from
Closed

Upgrade protobuf and grpcio #178

noamt wants to merge 3 commits into from

Conversation

@noamt
Copy link
Contributor

@noamt noamt commented Feb 10, 2023

As mentioned in issue #176 , the SDK cannot be used with Python 3.11.

This PR:

  • Upgrades to the latest version of grpc
  • Upgrades to the latest version of protobuf
  • Adds 3.11 to the build matrix

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rvorias
rvorias approved these changes Mar 15, 2023
View reviewed changes
Copy link

@rvorias rvorias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything worked.

@hnykda
Copy link

hnykda commented Apr 2, 2023

Great progress on getting stability run on M2 Macbook. However, we need to go further, as I am getting: grpc/grpc#32306

palp
palp approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@palp palp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@palp palp mentioned this pull request Apr 14, 2023
Merged
@palp
Copy link
Contributor

palp commented Apr 14, 2023

Merged in #209

@palp palp closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@palp palp palp approved these changes

@rvorias rvorias rvorias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noamt @hnykda @palp @rvorias