Un-hardcode "cuda" as default device name #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjaminaubin Rebased 🧹 |
|
@benjaminaubin ... and rebased again 🧹 |
Draft
|
Noticed a couple more spots where Also, rebased. |
akx
force-pushed
the
un-hardcode-cuda
branch
from
fafea56 to
021f12a
Compare
|
Rebased on 059d8e9. |
Allow configuring with `SGM_DEFAULT_DEVICE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring with
SGM_DEFAULT_DEVICE(but default to CUDA when available).This ought to make the repo a little bit easier to use with e.g. Apple Silicon; you can set
SGM_DEFAULT_DEVICE=mpsand go to town.Refs #6.
This does not touch the Streamlit demo, which is still hard-coded to use
cudain many places.